make unsupported_calling_conventions a hard error #129935
Conversation
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors try |
RalfJung
force-pushed
the
unsupported_calling_conventions
branch
from
d933cf5 to
0c5a9b3
Compare
…ions, r= make unsupported_calling_conventions a hard error This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were [not many crates hitting this](rust-lang#86231 (comment)) even when the PR was landed. This should get cratered, and I assume then it needs a t-compiler FCP. Fixes rust-lang#88397
This comment has been minimized.
This comment has been minimized.
|
Damn, this needs a change in the reference.^^ |
Waiting 24 hours will also unblock, since beta week ends. |
|
☀️ Try build successful - checks-actions |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
6 crates on crates.io are affected, those all look like genuine regressions. They are all rarely used (the one with most downloads has 12k total downloads, that one also has not seen any updates in 8 years). I have filed issues for the 4 crates that saw updates in the last 5 years, see the backlinks above. |
RalfJung
force-pushed
the
unsupported_calling_conventions
branch
from
0c5a9b3 to
2620cb2
Compare
|
@fee1-dead I think this is then ready for review. Does it need a t-compiler FCP because it is a breaking change? |
This comment has been minimized.
This comment has been minimized.
|
☀️ Test successful - checks-actions |
|
Reference should be fixed by rust-lang/reference#1600 |
|
Finished benchmarking commit (1de57a5): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 1.7%, secondary -0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 781.081s -> 779.742s (-0.17%) |
|
@RalfJung There is an additional test that needs to be fixed. I posted rust-lang/reference#1659 to fix that. |
13 participants
This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were not many crates hitting this even when the lint was originally added.
This should get cratered, and I assume then it needs a t-compiler FCP. (t-compiler because this looks entirely like an implementation oversight -- for the vast majority of ABIs, we already have a hard error, but some were initially missed, and we are finally fixing that.)
Fixes #87678